Repository navigation
fix(windows): add license files to the symbols zip and force LF - #552
Merged
Merged
Conversation
The repository owner decided on 2026-10-30, after the alpha.31 release review, that the symbols zip carries the package's LICENSE.txt and THIRD-PARTY-NOTICES.txt and that packaged text files use LF line endings regardless of the build host's Git configuration. package.ps1 now writes the four text files with LF and fails on a carriage return, and stages the symbols zip with the symbol files and both license files. .gitattributes also checks out the packaged files and LICENSE.txt with LF on every host. Refs: #506
Describe the bundled Profile as JSON-equal to the schema candidate, which is what the test asserts, and record the LF text files and the license and notices in the symbols zip. Refs: #506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the 2026-10-30 owner decisions added to the Wave entry "Windows 0.1.0-alpha Prereleases" in #551 (item 4): the symbols zip carries
LICENSE.txtandTHIRD-PARTY-NOTICES.txt, and the packaged text files use LF line endings regardless of the build host's Git configuration. Thev0.1.0-alpha.31draft (release 428540142) was deleted after #551 merged; no tag existed.Authorization and Governing Records
main-v2(3e4c623), "Asset contents (2026-10-30)" and item 4.Scope and Non-Goals
packaging/windows/package.ps1: writes the four package text files with LF (Write-LfText), fails if any contains CR, stages the symbols zip with the three PDBs plusLICENSE.txtandTHIRD-PARTY-NOTICES.txt..gitattributes:packaging/windows/** text eol=lfandLICENSE.txt text eol=lf(both already LF in the index; no renormalization diff).Record-System Impact
docs/designs/windows-ado-authentication.md;.gitattributes;packaging/windows/package.ps1.Evidence and Reasoning
Release-review findings A1 and A2 on
v0.1.0-alpha.31(#506).Identity and Security Effects
None.
Validation
hk check --allpassed; the script parses in PowerShell 7.package.ps1atb158130(full clone,-AllowNonPublicRelease, Wave restore route with an audited WSL fill: 0 warnings, 0 errors): exit 0; both checksums verify; package zip has the same six files; symbols zip has the three PDBs plusLICENSE.txtandTHIRD-PARTY-NOTICES.txt; none of the four text files contains CR; the packaged Profile is byte-identical to the repository file. The clone and outputs were deleted afterward.Review and Disposition
Accepted target-branch authorities used:
origin/main-v2(3e4c623) AGENTS.md, governance policies and catalogs, and both review Skills.packaging/windows/**would mark a future binary there as text; add a-textoverride if one is added.Upstream Provenance
None.